What comes into question most is some of his behaviour in the rink and out - much of it from his own stories and quotes - and his career choices.
Of course Johnny is self-involved - most elite skaters are, and many of us are too. Yes he's a bedside table thief by his own admission, but where did anyone say he has no redeeming attributes and has not grown as a person since he was a teen?
Good people do bad things, smart people make stupid choices. Everything is not black and white/love Johnny or hate him.