I don't think it's about being buttoned up or family friendly. Figure skating is a sport in the Olympics, where any kind of drug use is taken very seriously. Figure skating also struggles to be taken seriously as a sport and not just entertainment, so has to work even harder to prove that its participants are serious, trained, disciplined and talented athletes. References to drugs may be acceptable in the entertainment world, but not in sports.
If Johnny is so creative and expressive, surely he could have found other ways to describe programs, but IMO he did it for effect, to push the envelope, to tease people, and to test his boundaries with the USFSA and even the ISU/IOC.